RDKBACCL-1935: Minimalize the kernel modules for BPI-R4 extender build - #521
Open
ksaipr036 wants to merge 1 commit into
Open
RDKBACCL-1935: Minimalize the kernel modules for BPI-R4 extender build#521ksaipr036 wants to merge 1 commit into
ksaipr036 wants to merge 1 commit into
Conversation
ksaipr036
force-pushed
the
RDKBACCL-1935
branch
8 times, most recently
from
August 6, 2026 15:37
16fb978 to
d64c8d1
Compare
ksaipr036
marked this pull request as ready for review
August 6, 2026 15:46
cpokuru
reviewed
Aug 6, 2026
Reason for Change: Remove kernel modules that are not required for the extender build to optimize kernel configuration. Test Procedure: Verify that the basic EasyMesh(EM) functionality works as expected. Risks: None Signed-off-by: ksaipr036 <kosika_saipriya@comcast.com>
ksaipr036
force-pushed
the
RDKBACCL-1935
branch
from
August 7, 2026 13:40
d64c8d1 to
801f71c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (5)
meta-rdk-mtk-bpir4/recipes-kernel/linux/linux-mediatek_%.bbappend:7
- The
bb.utils.contains(..., ' ', ...)branches intentionally return a single space. This works but is easy to misread as a meaningful SRC_URI entry and can complicate debugging (especially when combined with line continuations). Prefer returning an empty string when you want to add nothing.
${@bb.utils.contains('DISTRO_FEATURES', 'em_extender', ' file://rdkb_cfg/iptables_nf_ext.cfg', ' file://rdkb_cfg/iptables_nf.cfg', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'em_extender', ' ', ' file://rdkb_cfg/bridge_mode.cfg', d)} \
meta-rdk-mtk-bpir4/recipes-kernel/linux/files/rdkb_cfg/kernel_v6_ext.cfg:67
- These lines are commented out as
#CONFIG_FOO=y, which does not disable a Kconfig option in a config fragment—it just turns the line into a comment. If the intent is to ensure these options are off for the extender build, use the standard disable syntax (# CONFIG_FOO is not setorCONFIG_FOO=n) instead of commenting out the assignment.
########################################
# REMOVING THE BELOW CFG FROM EXISTING #
########################################
#CONFIG_USB_UAS=y
#CONFIG_BT=y
meta-rdk-mtk-bpir4/recipes-kernel/linux/files/rdkb_cfg/iptables_nf_ext.cfg:20
- The kernel options below are commented out as
#CONFIG_FOO=y, which does not disable them in a Kconfig fragment. If the extender build must actively turn these modules off (even if enabled by a base defconfig or another fragment), use# CONFIG_FOO is not setinstead.
#==============================#
# Removing below kernel mod #
#==============================#
#CONFIG_USB_NET_QMI_WWAN=y
#CONFIG_BT_HCIBTUSB=y
meta-rdk-mtk-bpir4/recipes-kernel/linux/files/rdkb_cfg/container_ext.cfg:18
- These options are commented out as
#CONFIG_FOO=y, which does not disable them in a Kconfig fragment. If the extender build is meant to remove these container/cgroup features, use# CONFIG_FOO is not set(orCONFIG_FOO=n) so the fragment actually forces them off.
########################################
# REMOVING THE BELOW CFG FROM EXISTING #
########################################
#CONFIG_CGROUP_PIDS=y
#CONFIG_CGROUP_DEVICE=y
meta-rdk-mtk-bpir4/recipes-kernel/linux/files/rdkb_cfg/kernel_6_6_ext.cfg:25
- These lines are commented out as
#CONFIG_FOO=y, which does not disable a Kconfig option in a config fragment (it only comments the line). If the extender build needs these options forced off, switch to# CONFIG_FOO is not set(orCONFIG_FOO=n).
########################################
# REMOVING THE BELOW CFG FROM EXISTING #
########################################
#CONFIG_BT=y
#CONFIG_USB_NET_AX88179_178A=y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Remove kernel modules that are not required for the extender build to optimize kernel configuration.
Test Procedure: Verify that the basic EasyMesh(EM) functionality works as expected.
Risks: None